Avoid incorrect allocation in buildIndexArray - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Avoid incorrect allocation in buildIndexArray
Date
Msg-id 26C43E58-BDD0-4F1A-97CC-4A07B52E32C5@yesql.se
Whole thread Raw
Responses Re: Avoid incorrect allocation in buildIndexArray
List pgsql-hackers
Looking at a pg_dump patch I realized that when we call buildIndexArray without
having found objects to index, we still call pg_malloc with zero which in turn
mallocs 1 byte.  The byte in question is of course negligable, but it does seem
cleaner to return early with NULL instead of returning an empty allocation
which doesn't actually contain an index.

Any reason not to bail early as per the attached?

cheers ./daniel






Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: TDE (Transparent Data Encryption) supported ?
Next
From: Julien Rouhaud
Date:
Subject: Re: Avoid incorrect allocation in buildIndexArray