Re: Eager aggregation, take 3 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Eager aggregation, take 3
Date
Msg-id 2799576.1759976008@sss.pgh.pa.us
Whole thread Raw
In response to Re: Eager aggregation, take 3  (Richard Guo <guofenglinux@gmail.com>)
Responses Re: Eager aggregation, take 3
List pgsql-hackers
Richard Guo <guofenglinux@gmail.com> writes:
> On Wed, Oct 8, 2025 at 11:45 PM Robert Haas <robertmhaas@gmail.com> wrote:
>> For what it's worth, I also don't like that field name. I'm not sure
>> what to propose instead, but I don't think apply_at is very clear.

> This field represents the set of relids at which partial aggregation
> is applied.  So how about naming it partial_agg_designated_relids?
> That feels a bit verbose, though.  How about partial_agg_relids or,
> for brevity, agg_relids instead?

I might be missing a subtlety here, but how about
"apply_aggregation_at" or "apply_partial_agg_at"?

I don't think including "relids" in the field name adds anything,
given the field's declared type and comments.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH] Add tests for Bitmapset
Next
From: Richard Guo
Date:
Subject: Re: plan shape work