Re: plan shape work - Mailing list pgsql-hackers

From Richard Guo
Subject Re: plan shape work
Date
Msg-id CAMbWs4__ff1WGk7nRT+5a8nrXP93NJmQFyLe_2_jL0MPFYVRHw@mail.gmail.com
Whole thread Raw
In response to Re: plan shape work  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: plan shape work
List pgsql-hackers
On Tue, Oct 7, 2025 at 4:37 AM Robert Haas <robertmhaas@gmail.com> wrote:
> I see that Richard's PoC last patch confused cfbot. Here's a new
> version of just the patch proposed for commit for CfBot testing.

Does it make sense to explicitly initialize glob->subplanNames in
standard_planner()?  I understand this might seem pointless since
makeNode() zeroes all fields by default, but subplanNames is currently
the only field in PlannerGlobal that isn't explicitly initialized.  I
previously committed a patch (2c0ed86d3) to ensure all PlannerGlobal
fields are explicitly initialized, and I'd prefer to maintain that
consistency.

I actually suggested the same in [1] (the last paragraph), but it
seems to have been overlooked.

[1] https://postgr.es/m/CAMbWs4-ysLvZiWp=w5=+noCMdX9FHFrrc0Wuk-TcUz1RDmEbkQ@mail.gmail.com

- Richard



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Eager aggregation, take 3
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: [PROPOSAL] Termination of Background Workers for ALTER/DROP DATABASE