Re: xact_start for walsender & logical decoding not updated - Mailing list pgsql-hackers

From Tom Lane
Subject Re: xact_start for walsender & logical decoding not updated
Date
Msg-id 30804.1578438763@sss.pgh.pa.us
Whole thread Raw
In response to Re: xact_start for walsender & logical decoding not updated  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: xact_start for walsender & logical decoding not updated
List pgsql-hackers
I wrote:
> The buildfarm seems less than happy with this.

... and, having now looked at the patch, I'm not surprised.
Breaking stmtStartTimestamp, which is what you did, seems like
an awfully side-effect-filled route to the goal.  If you want
to prevent monitoring from showing this, why didn't you just
prevent monitoring from showing it?  That is, I'd have expected
some am_walsender logic in or near pgstat.c, not here.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andrew Gierth
Date:
Subject: Re: A rather hackish POC for alternative implementation of WITH TIES
Next
From: Melanie Plageman
Date:
Subject: Re: Extracting only the columns needed for a query