Re: Adding some error context for lock wait failures - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Adding some error context for lock wait failures
Date
Msg-id 3083139.1760031224@sss.pgh.pa.us
Whole thread Raw
In response to Re: Adding some error context for lock wait failures  (Andres Freund <andres@anarazel.de>)
Responses Re: Adding some error context for lock wait failures
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2025-10-09 12:50:53 -0400, Tom Lane wrote:
>> Concretely, like the attached.  This passes check-world, but
>> I can't test it under valgrind because I'm hitting the same
>> CREATE DATABASE failure skink is reporting.

> Sorry, was working on a fix when life rudely intervened.  Here's a quick
> temporary fix:

Thanks.  With that, I've confirmed that this change suppresses the
leak report in your example, and it also gets through the core
regression tests under valgrind (though I didn't run leak checking
for that).  That's enough to convince me that the fix is OK.

Do you have an opinion on whether to back-patch?  I'm leaning
in the direction of doing so, but it could be argued that it's
too much risk for a problem that we only know for sure exists
in master.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Invalid pointer access in logical decoding after error
Next
From: Masahiko Sawada
Date:
Subject: Re: VACUUM (PARALLEL) option processing not using DefElem the way it was intended