Re: pgsql: Add tests for '-f' option in dropdb utility. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Add tests for '-f' option in dropdb utility.
Date
Msg-id 30914.1574952369@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Add tests for '-f' option in dropdb utility.  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: pgsql: Add tests for '-f' option in dropdb utility.
List pgsql-committers
Amit Kapila <amit.kapila16@gmail.com> writes:
> The message expected by this test was: "FATAL:  terminating connection
> due to administrator command" which seems to be fine in most cases but
> not all.

I think the correct question to ask is "why not all cases"?

> I think we just need to change the expected message the same as in
> 013_crash_restart.pl to make this test pass on all platforms.

If DROP FORCE sometimes gives victim sessions the impression that the
server crashed, rather than that they were kicked off intentionally,
I think that's totally unacceptable.  "Fixing" this by changing the
test to allow it is not the answer, and if we can't find a better
answer, I'm going to vote to revert the feature.

            regards, tom lane



pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: pgsql: Add tests for '-f' option in dropdb utility.
Next
From: Amit Kapila
Date:
Subject: Re: pgsql: Add tests for '-f' option in dropdb utility.