Re: casting operand to proper type in BlockIdGetBlockNumber - Mailing list pgsql-hackers

From Tom Lane
Subject Re: casting operand to proper type in BlockIdGetBlockNumber
Date
Msg-id 3208660.1646329522@sss.pgh.pa.us
Whole thread Raw
In response to Re: casting operand to proper type in BlockIdGetBlockNumber  (Andres Freund <andres@anarazel.de>)
Responses Re: casting operand to proper type in BlockIdGetBlockNumber
Re: casting operand to proper type in BlockIdGetBlockNumber
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2022-03-03 12:13:40 -0500, Tom Lane wrote:
>> Hmph.  I tried enabling -fsanitize=undefined here, and I get some
>> complaints about passing null pointers to memcmp and the like, but
>> nothing about this shift (tested with clang 12.0.1 on RHEL8 as well
>> as clang 13.0.0 on Fedora 35).

> We should fix these passing-null-pointer cases...

Yeah, working on that now.  But I'm pretty confused about why I can't
duplicate this shift complaint.  Alma is a Red Hat clone no?  Why
doesn't its compiler act the same as RHEL8's?

> Need to manually add -ldl, because -fsanitize breaks our dl test (it uses
> dlopen, but not dlsym). Was planning to submit a fix for that...

Hmm ... didn't get through check-world yet, but I don't see that
so far.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: Problem with moderation of messages with patched attached.
Next
From: Andres Freund
Date:
Subject: Re: casting operand to proper type in BlockIdGetBlockNumber