Unify drop-by-OID functions - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Unify drop-by-OID functions
Date
Msg-id 331d9661-1743-857f-1cbb-d5728bcd62cb@2ndquadrant.com
Whole thread Raw
Responses Re: Unify drop-by-OID functions
Re: Unify drop-by-OID functions
List pgsql-hackers
[proposal for PG 14]

There are a number of Remove${Something}ById() functions that are 
essentially identical in structure and only different in which catalog 
they are working on.  This patch refactors this to be one generic 
function.  The information about which oid column, index, etc. to use 
was already available in ObjectProperty for most catalogs, in a few 
cases it was easily added.

Conceivably, this could be taken further by categorizing more special 
cases as ObjectProperty fields or something like that, but this seemed 
like a good balance.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: do {} while (0) nitpick
Next
From: Pavel Stehule
Date:
Subject: Re: Unify drop-by-OID functions