Re: pgsql: llvmjit: Use explicit LLVMContextRef for inlining - Mailing list pgsql-committers

From Daniel Gustafsson
Subject Re: pgsql: llvmjit: Use explicit LLVMContextRef for inlining
Date
Msg-id 3469A042-A3EB-4483-831D-0D8815D4EF41@yesql.se
Whole thread Raw
In response to Re: pgsql: llvmjit: Use explicit LLVMContextRef for inlining  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: llvmjit: Use explicit LLVMContextRef for inlining
List pgsql-committers
> On 19 Nov 2023, at 17:05, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> Daniel Gustafsson <dgustafsson@postgresql.org> writes:
>> llvmjit: Use explicit LLVMContextRef for inlining
> 
> It looks like the v12 back-port of this wasn't quite right:
> canebrake and urutu have both been showing assertion failures
> down inside LLVMContextDispose since it went in.  They aren't
> complaining about v13 and later, though.

Ugh, I had missed these =/ Thanks for the heads up!

> No idea what the cause may be, but perhaps the right answer
> is just to revert this and not try to fix the bug in v12?

I'll have a look with fresh eyes in the morning, and hopefully it will be
fixable.  If it get's messy it's quite possible that skipping v12 is the best
option.

--
Daniel Gustafsson




pgsql-committers by date:

Previous
From: Tomas Vondra
Date:
Subject: pgsql: Lock table in DROP STATISTICS
Next
From: Michael Paquier
Date:
Subject: pgsql: Prevent overflow for block number in buffile.c