Re: Correct comment wording in extension.c - Mailing list pgsql-hackers

From Chao Li
Subject Re: Correct comment wording in extension.c
Date
Msg-id 34C7C567-99BA-4AED-9A9C-46C3AAAAE5B4@gmail.com
Whole thread Raw
In response to Re: Correct comment wording in extension.c  (John Naylor <johncnaylorls@gmail.com>)
List pgsql-hackers

> On Jan 13, 2026, at 13:40, John Naylor <johncnaylorls@gmail.com> wrote:
>
> On Sun, Jan 11, 2026 at 11:58 AM Chao Li <li.evan.chao@gmail.com> wrote:
>> v4-0001 looks good to me.
>
> When I say I'm going to commit "unless/barring", no response is
> necessary unless there is a problem.
>
>> I just went through extension.c and got a few more comment improvements. I put them in v5-0002, please take a look.
>
> - * for them therefore uses about O(N^2) time when there are N versions of
> + * for them therefore uses O(N^2) time when there are N versions of
>
> - /* store the OID of the namespace to-be-changed */
> + /* store the OID of the namespace to be changed */
>
> Please read these responses to you from last week:
>
> https://www.postgresql.org/message-id/1909358.1767854695%40sss.pgh.pa.us
> https://www.postgresql.org/message-id/7k27ut6kugt2mizo5cy5wplbbrz4ccbkxvsc2iqu5yde344iya%40dxktdjw6uvi2
>
> I've pushed v4.
>

Sure, I have read them carefully.

But you really missed:
```
diff --git a/src/backend/commands/extension.c b/src/backend/commands/extension.c
index 596105ee078..a9529692ae3 100644
--- a/src/backend/commands/extension.c
+++ b/src/backend/commands/extension.c
@@ -2398,7 +2398,7 @@ pg_available_extension_versions(PG_FUNCTION_ARGS)

                                /*
                                 * Ignore already-found names.  They are not reachable by the
-                                * path search, so don't shown them.
+                                * path search, so don't show them.
                                 */
                                extname_str = makeString(extname);
                                if (list_member(found_ext, extname_str))
```

This is not the one in v4.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







pgsql-hackers by date:

Previous
From: Soumya S Murali
Date:
Subject: Re: [PATCH] Expose checkpoint reason to completion log messages.
Next
From: VASUKI M
Date:
Subject: Re: [PATCH] tests: verify renamed index functionality in alter_table