Request a Demo
Home   >   mailing lists

Re: [PATCH] tests: verify renamed index functionality in alter_table - Mailing list pgsql-hackers

From VASUKI M
Subject Re: [PATCH] tests: verify renamed index functionality in alter_table
Date
Msg-id CAE2r8H681eL_=sFk=_m+ohDtq0o=gdrNzq4B3hB67qhqRZi+Bg@mail.gmail.com
Whole thread Raw
In response to [PATCH] tests: verify renamed index functionality in alter_table  (Dharin Shah <dharinshah95@gmail.com>)
List pgsql-hackers
Tree view
Hi Dharin,

Thanks for addressing the FIXME in the alter_table regression test.

The change LGTM. Verifying both planner visibility via EXPLAIN and runtime correctness with a SELECT after the index rename is a solid improvement, and using the standard enable_seqscan/bitmapscan/indexonlyscan = off pattern keeps the test deterministic.

I tested the patch locally and it passes:

make check TESTS=alter_table

full make check

O/P: ok 206       + alter_table                               870 ms

I don’t see any issues with the approach.

Regards,
Vasuki M,
C-DAC,Chennai

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Correct comment wording in extension.c
Next
From: Michael Paquier
Date:
Subject: Re: JumbleQuery ma treat different GROUP BY expr as the same