Re: [HACKERS] logical replication apply to run with sync commit offby default - Mailing list pgsql-hackers

From Petr Jelinek
Subject Re: [HACKERS] logical replication apply to run with sync commit offby default
Date
Msg-id 3626d1be-7faa-7211-4960-ec4241989f7a@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] logical replication apply to run with sync commit offby default  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: [HACKERS] logical replication apply to run with sync commit offby default
List pgsql-hackers
On 12/04/17 06:10, Peter Eisentraut wrote:
> On 3/24/17 10:49, Petr Jelinek wrote:
>> Rebase after table copy patch got committed.
> 
> You could please sent another rebase of this, perhaps with some more
> documentation, as discussed downthread.
> 
> Also, I wonder why we don't offer the other values of
> synchronous_commit.  In any case, we should keep the values consistent.
> So on should be on and local should be local, but not mixing it.
> 

Now that I am back from vacation I took look at this again. The reason
why I did only boolean initially is that he other values just didn't
seem all that useful. But you are right it's better to be consistent and
there is no real reason why not to allow all of the possible values.

So how about the attached?

-- 
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Pierre Ducroquet
Date:
Subject: [HACKERS] Small patch for pg_basebackup argument parsing
Next
From: Petr Jelinek
Date:
Subject: Re: [HACKERS] Interval for launching the table sync worker