Re: ICU warnings during make installcheck and text_extensions test - Mailing list pgsql-hackers

From Oleg Tselebrovskiy
Subject Re: ICU warnings during make installcheck and text_extensions test
Date
Msg-id 36906e5cd7b07ae273a032e6068bb3be@postgrespro.ru
Whole thread Raw
In response to Re: ICU warnings during make installcheck and text_extensions test  (Alexander Korotkov <aekorotkov@gmail.com>)
List pgsql-hackers
Alexander Korotkov wrote at 2025-09-14 00:59:
> collate.icu.utf8.sql have a protection against running in
> inappropriate locale in the top.  It's OK to run it with any locale.
> If the locale doesn't match then it will be stopped in the beginning
> and alternative output collate.icu.utf8_1.out matched.

Thanks for the info!

> Great.  I'm not sure if we want this to be backpatched.  Yet pushed
> this to master.

Thanks for pushing this to master! But why not backpatch this?
Some of my coworkers use make installcheck extensively, and
have complained about the warnings. Those warnings could possibly
break some automated testing systems/scripts, but I haven't seen it.

And since PG16-17 will still be supported for a while, those warnings
will exist for this exact while :)

Also, to me the patch seems low-risk. Are such annoyances backpatched
often?

Regards, Oleg Tselebrovskiy



pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Remove PointerIsValid()
Next
From: Steven Niu
Date:
Subject: Re: pgbench: remove an unused function argument