Request a Demo
Home   >   mailing lists

Re: Buffer locking is special (hints, checksums, AIO writes) - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Buffer locking is special (hints, checksums, AIO writes)
Date
Msg-id 3je3ahgf7rrmmurxo6hnlhg5d3ffwfrtjwjxd6jm5srlv5iebp@vxqk5qtgmowr
Whole thread Raw
In response to Re: Buffer locking is special (hints, checksums, AIO writes)  (Matthias van de Meent <boekewurm+postgres@gmail.com>)
Responses Re: Buffer locking is special (hints, checksums, AIO writes)
List pgsql-hackers
Tree view 
Hi,

I pushed a few commits from this patchset after Matthias' review
(thanks!). Unfortunately in 5e899859287 I missed that the valgrind annotations
would not be done anymore for the buffers returned by
StrategyGetBuffer(). Which turned skink red.

The attached 0001 patch centralizes the valgrind initialization in
TrackNewBufferPin(), which 5e899859287 had added. The nice side effect of that
is that there are fewer VALGRIND_MAKE_MEM_DEFINED() calls than before. The
naming isn't the perfect match, but it seems fine to me.


0002 is a new version of "Allow some buffer state modifications while holding
header lock", mainly with a fair bit of comment polishing around BufferDesc
and one small oversight fixed (didn't update a buffer_state variable in one
place).

Greetings,

Andres Freund
Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: VACUUM (PARALLEL) option processing not using DefElem the way it was intended
Next
From: Greg Burd
Date:
Subject: Re: Expanding HOT updates for expression and partial indexes