Re: [HACKERS] [PATCH] Incremental sort - Mailing list pgsql-hackers

From Teodor Sigaev
Subject Re: [HACKERS] [PATCH] Incremental sort
Date
Msg-id 41aa271c-f97c-2d13-1b1a-c580b5e3a99d@sigaev.ru
Whole thread Raw
In response to Re: [HACKERS] [PATCH] Incremental sort  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] [PATCH] Incremental sort
List pgsql-hackers
> I dunno, how would you estimate whether this is actually a win or not?
> I don't think our model of sort costs is anywhere near refined enough
> or accurate enough to reliably predict whether this is better than
> just doing it in one step.  Even if the cost model is good, it's not
> going to be better than our statistics about the number/size of the
> groups in the first column(s), and that's a notoriously unreliable stat.
I think that improvement in cost calculation of sort should be a 
separate patch, not directly connected to this one. Postpone patches 
till other part will be ready to get max improvement for postponed ones 
doesn't seem to me very good, especially if it suggests some improvement 
right now.


-- 
Teodor Sigaev                      E-mail: teodor@sigaev.ru
                                       WWW: http://www.sigaev.ru/


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Bring atomic flag fallback up to snuff
Next
From: Andres Freund
Date:
Subject: Re: Online enabling of checksums