Re: Change GUC hashtable to use simplehash? - Mailing list pgsql-hackers

From Anton A. Melnikov
Subject Re: Change GUC hashtable to use simplehash?
Date
Msg-id 42304488-65ce-4604-854e-2aaf3bc8f09d@postgrespro.ru
Whole thread Raw
In response to Re: Change GUC hashtable to use simplehash?  (John Naylor <johncnaylorls@gmail.com>)
Responses Re: Change GUC hashtable to use simplehash?
List pgsql-hackers
Hi, John!

On 13.02.2025 04:49, John Naylor wrote:
> On Thu, Feb 13, 2025 at 3:42 AM Anton A. Melnikov
> <a.melnikov@postgrespro.ru> wrote:

>> On 29.01.2025 10:02, John Naylor wrote:
>>> This is done -- thanks for the report, and for testing.
>>
>> It's good that this is done! But i still see the problem.
> 
> Hi, my understanding was you previously tested with the revert. Did
> you not actually test, or are you building differently for these
> cases?

My first test [1] was made at b7493e1
while the second [2] at ecb8226a after reverting in the 235328ee.

The build process was the same in both cases.

Both [1] and [2] contain pg_rightmost_one_pos64() call
that lead to a valgrind error.

Also i did this test very far back at e97b672c88 [3]
and found no errors.


With the best regards,

-- 
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

[1] https://www.postgresql.org/message-id/a3a959f6-14b8-4819-ac04-eaf2aa2e868d%40postgrespro.ru
[2] https://www.postgresql.org/message-id/f3aa2d45-3b28-41c5-9499-a1bc30e0f8ec%40postgrespro.ru
[3] https://www.postgresql.org/message-id/4c739718-27d6-44fe-9113-56a251c13275%40postgrespro.ru



pgsql-hackers by date:

Previous
From: Sami Imseih
Date:
Subject: Re: [PATCH] Optionally record Plan IDs to track plan changes for a query
Next
From: Jeff Davis
Date:
Subject: Re: Statistics Import and Export