Re: ECPG Refactor: move sqlca variable in ecpg_log() - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: ECPG Refactor: move sqlca variable in ecpg_log()
Date
Msg-id 426af17c-6fc8-4e14-8ae0-e63f46b4c6cc@oss.nttdata.com
Whole thread Raw
In response to Re: ECPG Refactor: move sqlca variable in ecpg_log()  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers

On 2024/10/21 23:25, Fujii Masao wrote:
> 
> 
> On 2024/10/19 2:43, Tom Lane wrote:
>> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
>>> I've attached the latest version of the patch, now including the commit log.
>>> Unless there are any objections, I'll proceed with committing it.
>>
>> LGTM.  Maybe move down the sqlca variable declaration, so that the
>> declarations still match the order in which the variables are
>> initialized?  That's just cosmetic of course.
> 
> Thanks for the review! I've updated the patch accordingly, i.e.,
> moved the declaration of the sqlca variable right after fmt.
> The v3 patch is attached.

Pushed. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION




pgsql-hackers by date:

Previous
From: Jehan-Guillaume de Rorthais
Date:
Subject: Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails
Next
From: Pavel Borisov
Date:
Subject: Re: type cache cleanup improvements