Re: libpq thread-locking - Mailing list pgsql-patches

! int
   pthread_mutex_init(pthread_mutex_t *mp, void *attr)
   {
       *mp = CreateMutex(0, 0, 0);
+     if (*mp == NULL)
+         return 1;
+     return 0;
   }

Maybe it would be better to emulate what pthreads does.  Instead of
returing 1 to indicate an error, return an errno.  In the above case,
ENOMEM seems like a good fit.

Also, maybe you should check the passed in mutex pointer.  If its NULL,
you could return EINVAL.

--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/