Re: postmaster.pid - Mailing list pgsql-hackers-win32

From Tom Lane
Subject Re: postmaster.pid
Date
Msg-id 5278.1093367846@sss.pgh.pa.us
Whole thread Raw
In response to Re: postmaster.pid  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers-win32
Andrew Dunstan <andrew@dunslane.net> writes:
> Tom Lane wrote:
>> Should you not send the zero signal the same way
>> as other signals, and just let the recipient ignore it?

> Umm - my Linux manpage says that no signal is actually sent in these
> circumstances, just a check that we could send some other signal if we
> wanted to.

Sure, but all that we have to emulate is that there is no visible effect
on the target process.  If it receives and throws away a zero signal,
we're good.  (Especially since this isn't done often enough to be a
performance issue.)

> So Dave's patch is clearly wrong where it returns EINVAL. How we should
> distinguish between the other two cases I am less sure of - IANAWP ;-)

I think we could just return ESRCH always if we have no pipe for the
process.  The callers will actually treat these errnos the same anyway.

            regards, tom lane

pgsql-hackers-win32 by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: postmaster.pid
Next
From: Tom Lane
Date:
Subject: Re: REPOST: InitDB Failure on install