Re: Badly designed error reporting code in controldata_utils.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Badly designed error reporting code in controldata_utils.c
Date
Msg-id 5600.1457321676@sss.pgh.pa.us
Whole thread Raw
In response to Re: Badly designed error reporting code in controldata_utils.c  (Joe Conway <mail@joeconway.com>)
Responses Re: Badly designed error reporting code in controldata_utils.c
List pgsql-hackers
Joe Conway <mail@joeconway.com> writes:
> On 03/06/2016 05:47 PM, Tom Lane wrote:
>> That's much better, but is there a reason you're using exit(2)
>> and not exit(EXIT_FAILURE) ?

> Only because I was trying to stick with what was originally in
> src/bin/pg_controldata/pg_controldata.c

Meh.  It looks to me like the standard way to handle this
for code in src/common/ is exit(EXIT_FAILURE).
        regards, tom lane



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: WIP: Upper planner pathification
Next
From: Tom Lane
Date:
Subject: Re: WIP: Upper planner pathification