Re: Enhance Makefiles to rebuild objects on map file changes - Mailing list pgsql-hackers

From Chao Li
Subject Re: Enhance Makefiles to rebuild objects on map file changes
Date
Msg-id 633A9BF8-FEF2-471E-8FB2-2DD847D95B5C@gmail.com
Whole thread Raw
In response to Re: Enhance Makefiles to rebuild objects on map file changes  (Álvaro Herrera <alvherre@kurilemu.de>)
List pgsql-hackers


On Aug 19, 2025, at 23:43, Álvaro Herrera <alvherre@kurilemu.de> wrote:

On 2025-Aug-19, Chao Li wrote:

Hi John,

Let me explain the Makefile patch in this separate thread, as this is generic to all maps.

Let’s not use gb18030 as an example, instead, using utf8_and_win.

When any of the win-related map file changes, it suppose to automatically rebuild utf8_and_win.o.

WITHOUT this patch, after I touch a map file, it doesn’t rebuild the object file:

Hmm.  Yeah, this really looks somewhat bogus as you say.  I wonder
though if we shouldn't have the UCS_to_*.pl scripts generate a bunch of
"mapdeps.mk" files instead, or something like that, given that these
*.map files are themselves generated.

Also, I suspect you should do something about Meson, but I don't know
what that would look like.


Based on Tom’s response in the other thread [1], this is a problem with make, it’s worth fixing.

As suggested by Alvaro, I will study on the “mapdepds.mk” direction a little bit.

[1] https://www.postgresql.org/message-id/2814142.1759983649%40sss.pgh.pa.us

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/




pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Logical Replication of sequences
Next
From: Amit Kapila
Date:
Subject: Re: Logical Replication of sequences