On Thu, Oct 9, 2025 at 11:21 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> I saw a sequence replication patch was committed recently [1], so I
> was looking at the diffs. Below are a couple of observations:
>
> //////////
>
> 1.
> The following message seems overly long:
> errmsg("publication parameters are not applicable to sequence
> synchronization and will be ignored for sequences"));
>
> I saw the message was already discussed here [2], but at that time, it
> was not shortened much.
>
> How about something shorter? Some examples.
> errmsg("publication parameters will be ignored for sequences"));
> errmsg("publication parameters will be ignored for sequence replication"));
>
I thought about these alternatives but left in favor of clarity with a
longer message. However, I am fine to change if others also think so.
Let's wait and see if others have an opinion on this point.
> ======
>
> 2.
> +-- Specifying WITH clause in an ALL SEQUENCES publication will emit a NOTICE.
> +SET client_min_messages = 'NOTICE';
> +CREATE PUBLICATION regress_pub_for_allsequences_alltables_withclause
> FOR ALL SEQUENCES, ALL TABLES WITH (publish = 'insert');
> +CREATE PUBLICATION regress_pub_for_allsequences_withclause FOR ALL
> SEQUENCES WITH (publish_generated_columns = 'stored');
> +RESET client_min_messages;
>
> Why not also test WITH('publish_via_partition_root')?
>
It is not required to write a test with all the options, the current
set chosen seems sufficient.
--
With Regards,
Amit Kapila.
