Re: BUG #18224: message bug in libpqwalreceiver.c. - Mailing list pgsql-bugs

From Alexander Lakhin
Subject Re: BUG #18224: message bug in libpqwalreceiver.c.
Date
Msg-id 68138521-5345-8780-4390-1474afdcba1f@gmail.com
Whole thread Raw
In response to Re: BUG #18224: message bug in libpqwalreceiver.c.  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: BUG #18224: message bug in libpqwalreceiver.c.
List pgsql-bugs
Hello Daniel,

05.12.2023 16:44, Daniel Gustafsson wrote:
> Following the bouncing ball it turns out that restricting to 9.4+ (effectively
> reapplying 083d29c65b78 adapted to the callsites moved to a common function)
> across the board isn't doable since pg_basebackup requires IDENTIFY_SYSTEM for
> 9.1->9.3 to get the starttli.  Thus I opted for just fixing the error message
> and left the restriction on 9.4+ as future work for when it can be done across
> all callers.

Isn't IDENTIFY_SERVER a mistake in the comment added?:

+     * IDENTIFY_SERVER returns 3 columns in 9.3 and earlier, and 4 columns in
+     * 9.4 and onwards.

Best regards,
Alexander



pgsql-bugs by date:

Previous
From: Thomas Munro
Date:
Subject: Re: BUG #16925: ERROR: invalid DSA memory alloc request size 1073741824 CONTEXT: parallel worker
Next
From: jian he
Date:
Subject: Re: BUG #18238: Cross-partitition MERGE/UPDATE with delete-preventing trigger leads to incorrect memory access