Re: BUG #18224: message bug in libpqwalreceiver.c. - Mailing list pgsql-bugs

From Daniel Gustafsson
Subject Re: BUG #18224: message bug in libpqwalreceiver.c.
Date
Msg-id 9C3157E9-C42D-40E3-9A11-64E4F890CD4E@yesql.se
Whole thread Raw
In response to Re: BUG #18224: message bug in libpqwalreceiver.c.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: BUG #18224: message bug in libpqwalreceiver.c.
List pgsql-bugs
> On 4 Dec 2023, at 15:18, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Daniel Gustafsson <daniel@yesql.se> writes:
>> How about fixing the error message in the backbranches, with a comment why we
>> expect 3 and not 4 fields, and requiring 4 thus restricting to 9.4+ in HEAD?
>
> OK by me.

Following the bouncing ball it turns out that restricting to 9.4+ (effectively
reapplying 083d29c65b78 adapted to the callsites moved to a common function)
across the board isn't doable since pg_basebackup requires IDENTIFY_SYSTEM for
9.1->9.3 to get the starttli.  Thus I opted for just fixing the error message
and left the restriction on 9.4+ as future work for when it can be done across
all callers.

--
Daniel Gustafsson




pgsql-bugs by date:

Previous
From: king tomo
Date:
Subject: Re: BUG #18224: message bug in libpqwalreceiver.c.
Next
From: PG Bug reporting form
Date:
Subject: BUG #18229: Multiple vacuum queries fail after upgrading to 13.10