pgaio_io_get_id() type (was Re: Datum as struct) - Mailing list pgsql-hackers

From Peter Eisentraut
Subject pgaio_io_get_id() type (was Re: Datum as struct)
Date
Msg-id 70c784b3-f60b-4652-b8a6-75e5f051243e@eisentraut.org
Whole thread Raw
In response to Re: Datum as struct  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 31.07.25 19:17, Tom Lane wrote:
> Also I see a "// XXX" in pg_get_aios, which I guess is a note
> to confirm the data type to use for ioh_id?

Yes, the stuff returned from pgaio_io_get_id() should be int, but some 
code uses uint32, and also UINT32_MAX as a special marker.  Here is a 
patch that tries to straighten that out by using int consistently and -1 
as a special marker.

Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: index prefetching
Next
From: Peter Eisentraut
Date:
Subject: Re: Bug in brin_minmax_multi_distance_numeric()