Re: Modernizing SQL functions' result type coercions - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Modernizing SQL functions' result type coercions
Date
Msg-id 8442.1578496975@sss.pgh.pa.us
Whole thread Raw
In response to Re: Modernizing SQL functions' result type coercions  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
Heikki Linnakangas <hlinnaka@iki.fi> writes:
> In init_sql_fcache(), one comment says that the junkfilter is 
> responsible for injecting NULLs for dropped columns, and a later comment 
> says that the junk filter gets "rid of any dropped columns". That seems 
> contradictory; which is it? Or does "get rid of" mean "set to NULL"?

Yeah, the second comment is sloppily worded; the first one is more
accurate.

> Other than that, looks good to me.

Thanks for reviewing!  I'll fix that comment and push.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Modernizing SQL functions' result type coercions
Next
From: Stephen Frost
Date:
Subject: Re: weird libpq GSSAPI comment