Re: _isnan() on Windows - Mailing list pgsql-hackers

On 07/12/2018 10:20 AM, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> On Wed, Jul 11, 2018 at 09:13:40AM -0400, Alvaro Herrera wrote:
>>> I just pushed it before seeing your message.
>> Fine as well, thanks for picking this up.  The buildfarm shows no
>> failures about this patch.
> I scraped all the compiler warnings from the buildfarm this morning,
> and I see no new ones that could be blamed on this change, so I think
> we're good.
>
> bowerbird and hamerkop have some gripes like this:
>
>   bowerbird     | c:\perl64\lib\core\win32.h(218): warning C4005: 'isnan' : macro redefinition (src/pl/plperl/SPI.c)
[G:\prog\bf\root\HEAD\pgsql.build\plperl.vcxproj]
>   bowerbird     | c:\perl64\lib\core\win32.h(218): warning C4005: 'isnan' : macro redefinition (src/pl/plperl/Util.c)
[G:\prog\bf\root\HEAD\pgsql.build\plperl.vcxproj]
>   bowerbird     | c:\perl64\lib\core\win32.h(218): warning C4005: 'isnan' : macro redefinition
(src/pl/plperl/plperl.c)[G:\prog\bf\root\HEAD\pgsql.build\plperl.vcxproj]
 
>   bowerbird     | c:\perl64\lib\core\win32.h(218): warning C4005: 'isnan' : macro redefinition
[G:\prog\bf\root\HEAD\pgsql.build\hstore_plperl.vcxproj]
>   bowerbird     | c:\perl64\lib\core\win32.h(218): warning C4005: 'isnan' : macro redefinition
[G:\prog\bf\root\HEAD\pgsql.build\jsonb_plperl.vcxproj]
>   bowerbird     |   c:\perl64\lib\core\win32.h(218): warning C4005: 'isnan' : macro redefinition
(src/pl/plperl/SPI.c)[G:\prog\bf\root\HEAD\pgsql.build\plperl.vcxproj]
 
>   bowerbird     |   c:\perl64\lib\core\win32.h(218): warning C4005: 'isnan' : macro redefinition
(src/pl/plperl/Util.c)[G:\prog\bf\root\HEAD\pgsql.build\plperl.vcxproj]
 
>   bowerbird     |   c:\perl64\lib\core\win32.h(218): warning C4005: 'isnan' : macro redefinition
(src/pl/plperl/plperl.c)[G:\prog\bf\root\HEAD\pgsql.build\plperl.vcxproj]
 
>   bowerbird     |   c:\perl64\lib\core\win32.h(218): warning C4005: 'isnan' : macro redefinition
[G:\prog\bf\root\HEAD\pgsql.build\hstore_plperl.vcxproj]
>   bowerbird     |   c:\perl64\lib\core\win32.h(218): warning C4005: 'isnan' : macro redefinition
[G:\prog\bf\root\HEAD\pgsql.build\jsonb_plperl.vcxproj]
>
> but those were there before too.  Not sure if there's anything
> we can/should try to do about that.
>
>             


We actually undef a bunch of things in plperl.h to keep the compiler 
quiet. Maybe we need to add this to the list?

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services