Re: Convert sepgsql tests to TAP - Mailing list pgsql-hackers

From Joe Conway
Subject Re: Convert sepgsql tests to TAP
Date
Msg-id 9ad5c852-c962-48ae-b81b-5f36c4779285@joeconway.com
Whole thread Raw
In response to Re: Convert sepgsql tests to TAP  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
On 1/24/25 09:00, Andrew Dunstan wrote:
> 
> On 2025-01-24 Fr 7:25 AM, Peter Eisentraut wrote:
>> On 27.08.24 10:12, Peter Eisentraut wrote:
>>> Here is a new patch version.
>>>
>>> I simplified the uses of sed and awk inside the Perl script.  I also 
>>> fixed "make installcheck".  I noticed that meson installs sepgsql.sql 
>>> into the wrong directory, so that's fixed also. (Many of the 
>>> complications in this patch set are because sepgsql is not an 
>>> extension but a loose SQL script, of which it is now the only one.  
>>> Maybe something to address separately.)
>>>
>>> I did end up deciding to keep the old test_sepgsql script, because it 
>>> does have the documented purpose of testing existing installations.  
>>> I did change it so that it calls pg_regress directly, without going 
>>> via make, so that the dependency on make is removed.
>>
>> This has been committed.  And I understand there is a buildfarm client 
>> update available for the affected buildfarm members.
> 
> 
> 
> This should only be rhinoceros. Joe can pull this fix:
> https://github.com/PGBuildFarm/client-code/commit/60b72787036090c6bf829f5cef2b0b3e60f2a2db
> (or just copy the whole file from
> https://raw.githubusercontent.com/PGBuildFarm/client-code/refs/heads/main/PGBuild/Modules/TestSepgsql.pm)

Sure, I am delinquent on updating my buildfarm client so will do that as 
well as pull the fix. It might be the weekend before I have the time though.

This reminds me though that rhino is still running on CentOS 7 -- I need 
to upgrade that one of these days...

-- 
Joe Conway
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Convert sepgsql tests to TAP
Next
From: Andrew Dunstan
Date:
Subject: Re: why -Fdance archive format option works with ./pg_restore but not with ./pg_dump?