Request a Demo
Home   >   mailing lists

Re: why -Fdance archive format option works with ./pg_restore but not with ./pg_dump? - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: why -Fdance archive format option works with ./pg_restore but not with ./pg_dump?
Date
Msg-id daea5c30-19d7-455c-a9b4-1c0b5ea20eeb@dunslane.net
Whole thread Raw
In response to why -Fdance archive format option works with ./pg_restore but not with ./pg_dump?  (Srinath Reddy <srinath2133@gmail.com>)
Responses Re: why -Fdance archive format option works with ./pg_restore but not with ./pg_dump?
List pgsql-hackers
Tree view


On 2025-01-24 Fr 3:04 AM, Srinath Reddy wrote:


On Fri, Jan 24, 2025 at 1:42 AM Andrew Dunstan <andrew@dunslane.net> wrote:

`git blame` tells me that this switch statement goes back to 2001.
Seeking a reason at this distance is unlikely to be productive. Probably
we were not nearly as careful then as we are now about such things. Feel
free to submit a patch tightening the test.


Hi Andrew,
thanks for the reply,here's the patch for the same. 




I don't think we need a new file for this. pg_backup_utils.c is already there for routines common to pg_restore and pg_dump.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Joe Conway
Date:
Subject: Re: Convert sepgsql tests to TAP
Next
From: Melanie Plageman
Date:
Subject: Re: Eagerly scan all-visible pages to amortize aggressive vacuum