Hi Stephen,
On 4/6/18 3:02 PM, Stephen Frost wrote:
>
> Alright, changes I've made, since I got impatient and it didn't seem to
> make sense to bounce these back to David instead of just making them (I
> did discuss them with him on the phone today tho, just to be clear).
>
> - The PG_FILE_MODE_DEFAULT, PG_DIR_MODE_DEFAULT, et al, were confusing.
> Those constants are used for the default file/dir mode, sure, but what
> that actually *are* is the 'owner'-only style mode, so they've been
> changed to PG_FILE_MODE_OWNER, PG_DIR_MODE_OWNER, etc.
This is definitely better.
There were a few missed replacements in 01 so I fixed those.
> Things that still need doing:
>
> - Further discussion in the commit messages
Agreed, these need some more work. I'm happy to do that but I'll need a
bit more time. Have a look at the new patches and I'll work on some
better messages.
> - Perhaps a bit more review to try to minimize the risk that something
> breaks on Windows... Looked ok to me, but probably still some risk
> that the Windows buildfarm members fall over, though I suppose that's
> also what they're there for.
I did my best on this based on breakage from some of my other patches.
> David, if you could look through this again and make sure I didn't break
> anything with the changes made, and perhaps make improvements to the
> docs/comments/commit messages, that'd be helpful for getting this over
> the line.
I'm pretty happy with it overall. As you say, there could always be
more comments, but I'm not sure what to add without just running on.
New patches attached.
--
-David
david@pgmasters.net
