Re: pg_upgrade check for invalid databases - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: pg_upgrade check for invalid databases
Date
Msg-id B838A9C5-E643-4B98-95E4-6BA5E2A1E16A@yesql.se
Whole thread Raw
In response to Re: pg_upgrade check for invalid databases  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
> On 1 Nov 2024, at 01:36, Bruce Momjian <bruce@momjian.us> wrote:
> On Fri, Oct 25, 2024 at 01:55:57PM +0200, Daniel Gustafsson wrote:

>> In the meantime, the OP has a good point that it's a tad silly that pg_upgrade
>> fails hard on invalid databases instead of detecting and reporting like how
>> other errors are handled.  The attached adds this check and expands the report
>> wording to cover it.
>
> Agreed.

I've applied this part, the discussion on whether or not pg_upgrade should gain
capabilities to skip and/or fix issues should probably be carried over in a new
thread.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Eager aggregation, take 3
Next
From: Karina Litskevich
Date:
Subject: Re: Add missing tab completion for ALTER TABLE ADD COLUMN IF NOT EXISTS