Re: Patch for ALTER DATABASE WITH TABLESPACE - Mailing list pgsql-hackers

From Bernd Helmle
Subject Re: Patch for ALTER DATABASE WITH TABLESPACE
Date
Msg-id BFA2800A5DD0D2E0DFB25242@imhotep.credativ.de
Whole thread Raw
In response to Patch for ALTER DATABASE WITH TABLESPACE  (Guillaume Lelarge <guillaume@lelarge.info>)
Responses Re: Patch for ALTER DATABASE WITH TABLESPACE
List pgsql-hackers
--On Donnerstag, November 06, 2008 11:35:54 +0100 Guillaume Lelarge
<guillaume@lelarge.info> wrote:

> Guillaume Lelarge a écrit :
>> v4 patch attached.
>>
>
> v5 patch attached.
>

Thanks Guillaume.

Maybe this is nit-picking, but i see that you have to rmdir() an existing
empty tablespace directory to use copydir() afterwards. Maybe we can teach
copydir() to error out when trying to mkdir() an existing directory only
when forced by the caller? I see copydir() used at four places, so the
impact of this change would be minimal.

--  Thanks
                   Bernd


pgsql-hackers by date:

Previous
From: Greg Smith
Date:
Subject: Re: [WIP] In-place upgrade
Next
From: "Robert Haas"
Date:
Subject: Re: [WIP] In-place upgrade