Checkpoint start logging is done inside critical section - Mailing list pgsql-hackers

From Ants Aasma
Subject Checkpoint start logging is done inside critical section
Date
Msg-id CA+CSw_v5_gGVQgS2i1rg_hGwiCeGYyomB8u8VoXSY=T4+4DybQ@mail.gmail.com
Whole thread Raw
Responses Re: Checkpoint start logging is done inside critical section
List pgsql-hackers
The LogCheckpointStart() call inside CreateCheckPoint() is done while
inside a critical section. The elog call could trigger errors due to
memory allocations or from a logging hook, resulting in a panic. It
seems better to postpone the logging until after the critical section
is done. It's only a few lwlock acquisitions away and shouldn't make
any material difference. Patch to do so is attached.

Regards,
Ants Aasma

Attachment

pgsql-hackers by date:

Previous
From: Larry Rosenman
Date:
Subject: Re: DSM robustness failure (was Re: Peripatus/failures)
Next
From: "Tsunakawa, Takayuki"
Date:
Subject: RE: Implementation of Flashback Query