Re: generic plans and "initial" pruning - Mailing list pgsql-hackers

Hi Junwang,

On Sun, Feb 16, 2025 at 1:37 PM Junwang Zhao <zhjwpku@gmail.com> wrote:
> On Sat, Feb 15, 2025 at 3:51 PM Amit Langote <amitlangote09@gmail.com> wrote:
> > Thanks! It looks like I missed updating the MERGE-related lists in ModifyTable.
> >
> > I've attached a fix with a test added based on your example. I plan to
> > push this on Monday.
> >
>
> I applied the patch and the problem solved,

Thanks for checking.

> I have a small question that
> should the following line
>
> ```
> if (node->mergeActionLists == NIL)
> ```
>
> be changed to
>
> ```
> if (mtstate->mt_mergeActionLists == NIL)
> ```
>
> ISTM that if we have pruned all the merge actions, there is no harm we
> omit setting mtstate->mt_merge_subcommands to 0.

Yeah, that seems harmless, so done.

I have pushed the fix now.

--
Thanks, Amit Langote