Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query - Mailing list pgadmin-hackers
Argh, I ran some tests, but didn't spot any lost messages in the tests I ran. I'll revert the patch.
--
Khushboo;
Please look at the following:
- Fix the patch so it doesn't drop messages.
- Add regression tests to make sure it doesn't break in the future. This may require creating one or more functions the spew out a whole lot of notices, and then running a couple of queries and checking the output.
- Check the messages panel on the history tab. I just noticed it seems to only be showing an even smaller subset of the messages.
Thanks.
On Mon, Feb 26, 2018 at 4:23 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Sent bit early,You can run 'VACUUM FULL VERBOSE' in query tool and verify the populated messages (pgAdmin3 vs. pgAdmin4).On Mon, Feb 26, 2018 at 9:48 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Khushboo/Dave,With given commit, I'm again seeing the issue raised in https://redmine.postgresql.org/issues/1523 :( --Regards,On Mon, Feb 26, 2018 at 7:49 PM, Dave Page <dpage@pgadmin.org> wrote:Ensure we pick up the messages from the current query and not a previous one. Fixes #3094
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif f;h=08b3ccc01a4d57e8ea3657f888 2a53dcd1b99386
Author: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Modified Files
--------------
web/pgadmin/utils/driver/abstract.py | 1 +
web/pgadmin/utils/driver/psycopg2/__init__.py | 64 +++++++++------------------
2 files changed, 21 insertions(+), 44 deletions(-)
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
pgadmin-hackers by date: