Re: Obsolete comment in postgres_fdw.c - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Obsolete comment in postgres_fdw.c
Date
Msg-id CA+TgmoYtrptZ7YBTyTSi-uLFOYx5Up4_8ijPBznK35a5RGcU-Q@mail.gmail.com
Whole thread Raw
In response to Re: Obsolete comment in postgres_fdw.c  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
List pgsql-hackers
On Mon, Mar 14, 2016 at 4:31 AM, Etsuro Fujita
<fujita.etsuro@lab.ntt.co.jp> wrote:
>> It was left there intentionally to document all the conditions in one
>> place (some from the core and some from the FDW itself), for a ready
>> reference. In case tomorrow core thinks that matching user mapping is
>> not required, postgres_fdw would still require it to be incorporated.
>
> Thank you for the explanation!  I understand the reason, but that seems
> confusing to me.

Agreed.

>>     In addition, I'd like to update some related comments in
>>     src/include/nodes/relation.h and
>> src/backend/optimizer/path/joinpath.c.
>>
>>
>> Those look fine. Sorry for missing those in the commit and thanks for
>> providing a patch for the same.
>
> No problem.

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: Speed up Clog Access by increasing CLOG buffers
Next
From: Thomas Munro
Date:
Subject: Re: Proposal: "Causal reads" mode for load balancing reads without stale data