Re: On disable_cost - Mailing list pgsql-hackers

From Robert Haas
Subject Re: On disable_cost
Date
Msg-id CA+Tgmob=BuOyoiUtGYs=XVWTiXpDKDQwRTXtckp+Bysic2sT7g@mail.gmail.com
Whole thread Raw
In response to Re: On disable_cost  (Laurenz Albe <laurenz.albe@cybertec.at>)
Responses Re: On disable_cost
List pgsql-hackers
On Fri, Sep 27, 2024 at 4:42 AM Laurenz Albe <laurenz.albe@cybertec.at> wrote:
> 1. The "disabled nodes" are always displayed.
>    I'd be happier if it were only shown for COSTS ON, but I think it
>    would be best if they were only shown with VERBOSE ON.
>
>    After all, the messages are pretty verbose...

I agree that the messages are more verbose than what we did before
(add a large value to the cost). But I would have thought it wouldn't
matter much because most of the time nothing will be disabled. And I
would think if you get a plan that has some nodes disabled, you would
want to know about that.

I actually thought it was rather nice that this system lets you show
the disabled-nodes information even when COSTS OFF. Regression tests
need to suppress costs because it can vary by platform, but the count
of disabled nodes is stable enough to display.

--
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: On disable_cost
Next
From: Robert Haas
Date:
Subject: Re: pg_verifybackup: TAR format backup verification