Request a Demo
Home   >   mailing lists

Re: RecoveryInProgress() has critical side effects - Mailing list pgsql-hackers

From Robert Haas
Subject Re: RecoveryInProgress() has critical side effects
Date
Msg-id CA+Tgmobrw_+7F5JmYQP4u4sZRqE1MExPFGMAOuA-TfW1=NghJA@mail.gmail.com
Whole thread
In response to Re: RecoveryInProgress() has critical side effects  (Michael Paquier <michael@paquier.xyz>)
Responses Re: RecoveryInProgress() has critical side effects
List pgsql-hackers
Tree view 
On Sat, Dec 4, 2021 at 7:44 PM Michael Paquier <michael@paquier.xyz> wrote:
> My main worry here is that this changes slightly the definition of
> doPageWrites across stable branches at the end of recovery as there
> could be records generated there.  Note that GetFullPageWriteInfo()
> gets called in XLogInsert(), while Insert->fullPageWrites gets updated
> before CleanupAfterArchiveRecovery().  And it may influence
> the value of doPageWrites in the startup process.

But ... so what? All the code that uses it retries if the value that
was tentatively used turns out to be wrong.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: "Bossart, Nathan"
Date:
Subject: Re: Should we improve "PID XXXX is not a PostgreSQL server process" warning for pg_terminate_backend(<>)?
Next
From: Peter Geoghegan
Date:
Subject: Re: Why doesn't pgstat_report_analyze() focus on not-all-visible-page dead tuple counts, specifically?