Postgres Pro
Downloads
Home   >   mailing lists

Requesting external_pid_file with postgres -C when not initialized lead to coredump - Mailing list pgsql-hackers

From alain radix
Subject Requesting external_pid_file with postgres -C when not initialized lead to coredump
Date
Msg-id CA+YdpwwjBdZ9=kNkd0OUXKDT82CwucZJu2eW5_4SgJ3h5+=ApA@mail.gmail.com
Whole thread Raw
Responses Re: Requesting external_pid_file with postgres -C when not initialized lead to coredump
List pgsql-hackers
Tree view
Hi,

I faced a coredump when reading the value of the parameter "external_pid_file" when it was not initialized in postgresql.conf
This came from the value not being specified to be initialized to en empty string in guc.c in the ConfigureNamesString array.
the behavior can easily been tested with the following commands :
initdb test
postgres -D test -C external_pid_file

I faced the problem with version 9.3, 9.5 and 9.6 beta 1
This seems to come from a long time ago.

I wrote a patch ( with help from Stéphane Schildknecht ) to correct the problem with a proper initialization.
The patch also removed a useless initialization of cluster_name to save a little memory.

So, here is my first patch for PostgreSQL.

Best regards.

--
Alain Radix
Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Lets (not) break all the things. Was: [pgsql-advocacy] 9.6 -> 10.0
Next
From: Robert Haas
Date:
Subject: Re: Hash Indexes