Re: Pgoutput not capturing the generated columns - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Pgoutput not capturing the generated columns
Date
Msg-id CAA4eK1+LihJd5FmmXXxcUD_9bgCsXZqF+PcxDU_p8OK_CUzw_Q@mail.gmail.com
Whole thread Raw
In response to Re: Pgoutput not capturing the generated columns  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Pgoutput not capturing the generated columns
List pgsql-hackers
On Fri, Jan 24, 2025 at 8:39 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Amit Kapila <amit.kapila16@gmail.com> writes:
> > On Fri, Jan 24, 2025 at 4:41 AM Peter Smith <smithpb2250@gmail.com> wrote:
> >> However, in hindsight, I am not sure that the column should have been
> >> renamed 'pubgencols_type' in the first place because I cannot find any
> >> other catalogs with an underscore in their column names.
>
> > See pg_rewrite.ev_type for a similar case.
>
> I think the problem is not so much the underscore as the
> inconsistency.  You've got "pub", "gen", and "cols" run together,
> but then you feel a need to separate "type"?
>

It was easy to read and to avoid getting a single word too long.
However, I do understand your concern. so will change it to
pubgencolstype unless you or someone prefers pubgencols?

--
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Pgoutput not capturing the generated columns
Next
From: Tom Lane
Date:
Subject: Re: Pgoutput not capturing the generated columns