Re: Handle infinite recursion in logical replication setup - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Handle infinite recursion in logical replication setup
Date
Msg-id CAA4eK1JX-8951WN=_hHtU6xE4Pnv5yMwwSxA2ShykpxvAuSakQ@mail.gmail.com
Whole thread Raw
In response to Re: Handle infinite recursion in logical replication setup  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: Handle infinite recursion in logical replication setup
List pgsql-hackers
On Thu, May 26, 2022 at 7:06 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
>
> 3. doc/src/sgml/catalogs.sgml
>
> +      <para>
> +       If true, the subscription will request that the publisher send locally
> +       originated changes. False indicates that the publisher sends any changes
> +       regardless of their origin.
> +      </para></entry>
>
> SUGGESTION
> If true, the subscription will request the publisher to only send
> changes that originated locally.
>
> ~~~
>

I think it is a good idea to keep the description related to the
'False' value as without that it is slightly unclear.

> 4. doc/src/sgml/ref/create_subscription.sgml
>
> +         <para>
> +          Specifies whether the subscription will request the publisher to send
> +          locally originated changes at the publisher node, or send any
> +          publisher node changes regardless of their origin. The default is
> +          <literal>false</literal>.
> +         </para>
>
> This wording should be more similar to the same information in catalogs.sgml
>
> SUGGESTION
> Specifies whether the subscription will request the publisher to only
> send changes that originated locally, or to send any changes
> regardless of origin.
>
> ~~~
>

Here, also, let's keep the wording related to the default value.

-- 
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Gurjeet Singh
Date:
Subject: Re: Patch: Don't set LoadedSSL unless secure_initialize succeeds
Next
From: Shinya Kato
Date:
Subject: Re: Add --{no-,}bypassrls flags to createuser