Re: Have SIGHUP instead of SIGTERM for config reload in logical replication launcher - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Have SIGHUP instead of SIGTERM for config reload in logical replication launcher
Date
Msg-id CAA4eK1JcNMyO3n2ds0=3iLdb7E2thpEz8Hf516h6HxzEho4anQ@mail.gmail.com
Whole thread Raw
In response to Re: Have SIGHUP instead of SIGTERM for config reload in logical replication launcher  (Dilip Kumar <dilipbalaut@gmail.com>)
Responses Re: Have SIGHUP instead of SIGTERM for config reload in logical replication launcher
List pgsql-hackers
On Wed, Jul 15, 2020 at 6:21 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>
> On Wed, Jul 15, 2020 at 6:17 PM Bharath Rupireddy
> <bharath.rupireddyforpostgres@gmail.com> wrote:
> >
> > Hi,
> >
> > In ApplyLauncherMain, it seems like we are having SIGTERM signal
> > mapped for config reload. I think we should be having SIGHUP for
> > SignalHandlerForConfigReload(). Otherwise we miss to take the updated
> > value for wal_retrieve_retry_interval in ApplyLauncherMain.
> >
> > Attached is a patch having this change.
> >
> > Thoughts?
>
> Yeah, it just looks like a typo so your fix looks good to me.
>

+1.  I will commit this tomorrow unless someone thinks otherwise.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: renaming configure.in to configure.ac
Next
From: Amit Kapila
Date:
Subject: Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions