Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_rewind with --write-recovery-conf option doesn't write dbname to primary_conninfo value. - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: pg_rewind with --write-recovery-conf option doesn't write dbname to primary_conninfo value.
Date
Msg-id CAA4eK1KwMcLrFPL8nBzYmAJvqiDYaJGqBKjpQM+oSgq5F9g=9A@mail.gmail.com
Whole thread Raw
List pgsql-hackers
Tree view 
On Thu, Jan 30, 2025 at 3:17 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> I found that pg_rewind with --write-recovery-conf option doesn't write
> the dbname to an auto-generated primary_conninfo value. Therefore,
> after a failover, the old primary cannot start if it's rewound by
> pg_rewind with --write-recovery-conf option if sync_replication_slots
> is on. Is it an oversight in commit a145f424d5?
>

IIRC, we tried to do minimal in the first version as we didn't have
all the use cases. However, it makes sense to support this in HEAD as
proposed by you.

--
With Regards,
Amit Kapila.

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Increased work_mem for "logical replication tablesync worker" only?
Next
From: Peter Smith
Date:
Subject: Re: Introduce XID age and inactive timeout based replication slot invalidation