Re: [BUG] temporary file usage report with extended protocol and unnamed portals - Mailing list pgsql-hackers

From Sami Imseih
Subject Re: [BUG] temporary file usage report with extended protocol and unnamed portals
Date
Msg-id CAA5RZ0saywFCjKFrSS9p2Yv4o35o0yh9JnHW+SEs9KCeOhbD=A@mail.gmail.com
Whole thread Raw
In response to Re: [BUG] temporary file usage report with extended protocol and unnamed portals  (Mircea Cadariu <cadariu.mircea@gmail.com>)
Responses Re: [BUG] temporary file usage report with extended protocol and unnamed portals
Re: [BUG] temporary file usage report with extended protocol and unnamed portals
List pgsql-hackers
> > v16 is based on [0], with updates to the documentation and tests.
>
> Thanks for the updated patch!
>
> > +ok( $node->log_contains(qr/STATEMENT:\s+SELECT a FROM foo ORDER BY a
> > OFFSET \$1/s, $log_offset),
> >      "bind and implicit transaction, no statement logged");
> Should it actually be "statement correctly logged" instead of "no
> statement logged"?

oops, you're right.

We can actually remove "temporary file removed"
and "no statement logged" since we expect the
logging to blame the correct query in all these cases.

See v17

--
Sami Imseih
Amazon Web Services (AWS)

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
Next
From: Sami Imseih
Date:
Subject: Re: Bug in pg_stat_statements