On Wed, Oct 29, 2025 at 04:58:22PM -0500, Sami Imseih wrote:
> We can actually remove "temporary file removed"
> and "no statement logged" since we expect the
> logging to blame the correct query in all these cases.
While looking at the surroundings, I have noticed one comment on top
of the call of CreatePortal() in exec_simple_query() where an unnamed
portal is created, telling about a portal drop, but this still applies
to a succession of normal queries with for example rollbacks quickly
complaining (behavior documented). The same could still be said for
exec_bind_message() for CreatePortal() with an unnamed portal, still I
agree with the change in the docs that the completion of an unnamed
portal is more relevant to mention. So the doc change should be OK.
Some of the comments in the test were not correctly updated, I have
fixed these.
After looking again at the thread, I have decided to credit all three
of you as authors of this patch. Frederic has spent what I guess is a
lot of time on analyzing this, and then both Sami and Mircea have
followed up. This way, nobody should be jealous.
Then done on HEAD. If this proves to be a problem and that we have to
revert 1fd981f05369 for v19, at least we'll have the tests moving
forward. Anyway, let's have this change brew for now.
--
Michael
