Re: pgsql: Add tests for reinit.c - Mailing list pgsql-committers

From Andrew Dunstan
Subject Re: pgsql: Add tests for reinit.c
Date
Msg-id CAA8=A79CPVDWRgwFtowYODgu9i4p1zUsx6dpxDueRO_hxoJVJw@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Add tests for reinit.c  (David Steele <david@pgmasters.net>)
Responses Re: pgsql: Add tests for reinit.c
List pgsql-committers
On Mon, Mar 19, 2018 at 11:33 PM, David Steele <david@pgmasters.net> wrote:
> On 3/19/18 4:15 AM, Andrew Dunstan wrote:
>>
>> The attached fixes it. We should probably put the function or something
>> like it in TestLib.pm, though. The call to pwd is quite tricky - it
>> needs to be done pretty much exactly like this, not quite sure why, but
>> direct calls to "pwd -W" via system() or backticks don't work, only this
>> indirect call works on jacana.
>
> Thanks for the patch, Andrew!
>
> Peter, would you like me to provide a patch that moves this function to
> TestLib.pm?  Happy to do it, just don't want patches crossing in the
> night, as it were.
>

I've reworked it and pushed the fix.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pgsql: Don't use an Msys virtual path to create a tablespace
Next
From: Tom Lane
Date:
Subject: pgsql: Fix some corner-case issues in REFRESH MATERIALIZED VIEWCONCURR