Postgres Pro
Downloads
Home   >   mailing lists

Re: ALTER COLUMN ... SET EXPRESSION to alter stored generated column's expression - Mailing list pgsql-hackers

From Amul Sul
Subject Re: ALTER COLUMN ... SET EXPRESSION to alter stored generated column's expression
Date
Msg-id CAAJ_b96Pjr57hNgAjs9vOE+kRnEv4XJs5tboq2_+o+xHoXNeWw@mail.gmail.com
Whole thread Raw
In response to Re: ALTER COLUMN ... SET EXPRESSION to alter stored generated column's expression  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: ALTER COLUMN ... SET EXPRESSION to alter stored generated column's expression
Re: ALTER COLUMN ... SET EXPRESSION to alter stored generated column's expression
List pgsql-hackers
Tree view
On Tue, Nov 7, 2023 at 8:21 PM Peter Eisentraut <peter@eisentraut.org> wrote:
On 25.10.23 08:12, Amul Sul wrote:
> Here is the rebase version for the latest master head(673a17e3120).
>
> I haven't done any other changes related to the ON UPDATE trigger since that
> seems non-trivial; need a bit of work to add trigger support in
> ATRewriteTable().
> Also, I am not sure yet, if we were doing these changes, and the correct
> direction
> for that.

I did some detailed testing on Db2, Oracle, and MariaDB (the three
existing implementations of this feature that I'm tracking), and none of
them fire any row or statement triggers when the respective statement to
alter the generation expression is run.  So I'm withdrawing my comment
that this should fire triggers.  (I suppose event triggers are available
if anyone really needs the functionality.)

Thank you for the confirmation. 

Here is the updated version patch. Did minor changes to documents and tests.

Regards,
Amul


Attachment

pgsql-hackers by date:

Previous
From: "Zakhlystov, Daniil (Nebius)"
Date:
Subject: Re: Force the old transactions logs cleanup even if checkpoint is skipped
Next
From: Dean Rasheed
Date:
Subject: Re: Infinite Interval