Re: PATCH: pgAdmin4 debian installer - Mailing list pgadmin-hackers
Hello Dave and Devrim,
Changes are done as per discussed with Sandeep.
There are some python modules which are not available on ubuntu (through apt-get) which is mentioned in the sheet here , We could find some packages on web and the URLs of same have been updated in the sheet. For the packages that are not available, we have to build them on our own.
Attached is the patch for pgadmin4 debian package. I have also attached runtime server patch separately (This is already included in the rpm patch sent by Sandeep)
On Mon, May 9, 2016 at 6:45 PM, Dave Page <dave.page@enterprisedb.com> wrote:
HiPlease see my earlier comments regarding the RPM packages - many of them apply to this patch as well: http://www.postgresql.org/message-id/CA+OCxoxBDt82P75Q4Cy4fBkznkPBW3YJwPz+wFARbBBSoi3fgg@mail.gmail.comBy way of additional comment, why does pkg/deb/README include a bunch of boiler-plate text that I wrote long ago for the top-level README? It's out of date now, and shouldn't be in a packaging README anyway.Thanks.--On Tue, Apr 26, 2016 at 4:20 PM, Paresh More <paresh.more@enterprisedb.com> wrote:Hi Team, Dave,debian package is located @ locationpgadmin4-webpgadmin4-runtimeAttached herewith are two patches.pgadmin4_debian.patch - This is the main patch that includes Makefile,README,debian scriptsIt will create two .deb i.e pgadmin4-runtime and pgadmin4-web.The pgadmin4-runtime depends on web and the web debian depends on the python packages.I have listed some packages which are not available on some systems so that Devrim can build them.The installation path for pgadmin4 is "/usr/pgadmin4/<major>.<minor>" and pgadmin4-web is the site-packages/pgadmin4-webAs per rpm patch (sandeep mentioned) below is the comment which applies same for debian.pgadmin4-server-ini.patch - This is the patch for runtime/Server.cpp. As said pgadmin4-web and runtime installation directories are different andthat means web does not exists in parallel to runtime like in sources.Sandeep comments“I observed that the location of application settings was not defined inServer.cpp. As per QSettings doc, the default location on Unix is the$HOME/.config/<companyname>/<appname>.conf. Here, $HOME depends on the userthat runs the application. So, I thought why not to define the applicationsettings in application directory itself. RPM then knows where to definethe ApplicationPath. I tested it and it worked fine with me. I haven't donethis change for platform dependentAnother change that I did in this file is that, I observed that canonicalPath()was not giving the absolute path (by removing the sym link and theredundant ".." as per doc). Hence, I used absolutePath() for the paths[i]that are relative (../web, etc) and not for the already absolute path (ex.ApplicationPath like /usr/lib/python2.7/site-packages/pgadmin4-web)”What the patch will create ?- It would create deb folder in pkg- It would create Makefile, README and debian scripts--Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
Attachment
pgadmin-hackers by date: