Re: Add comment explaining why queryid is int64 in pg_stat_statements - Mailing list pgsql-hackers

From David Rowley
Subject Re: Add comment explaining why queryid is int64 in pg_stat_statements
Date
Msg-id CAApHDvoQA6s9oKCfoXotwOEYzxmh7MxFLFq5zYjebhBEvkhuVQ@mail.gmail.com
Whole thread Raw
In response to Re: Add comment explaining why queryid is int64 in pg_stat_statements  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Tue, 20 May 2025 at 17:09, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Mon, May 19, 2025 at 08:43:25PM -0700, Lukas Fittl wrote:
> > Yeah, +1 to making this consistent across both query ID and the new plan
> > ID, and changing both to int64 internally seems best.
>
> Any thoughts from others?  I'm OK to take the extra step of switching
> both fields on HEAD and write a patch for that, relying on what David
> has sent as a first step towards that.

Given the planId stuff is new and has the same issue, I think that
pushes me towards thinking now is better than later for fixing both.

I'm happy to adjust my patch unless you've started working on it already.

David



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: wrong query results on bf leafhopper
Next
From: Dilip Kumar
Date:
Subject: Re: [PATCH] Allow parallelism for plpgsql return expression after commit 556f7b7