On Fri, 11 Oct 2024 at 04:25, James Hunter <james.hunter.pg@gmail.com> wrote:
> Moved into restrictinfo.h, instead, in next revision.
Thanks. Pushed.
> > (I really wonder how much the inlining is giving us given that the
> > function itself calls other non-inlineable functions)
>
> I wondered the same! But, at least the branch can be inlined?
Do you mean function call? As far as I see it, that's the only
advantage. There are no branches that can be eliminated from
constant-folding.
I imagine the original version was only inlined to help coax the
compiler into inlining, which I imagine it would have done anyway if
there was just a single usage of the static function. Probably the
analyzejoins.c version just copied the original joinpath.c version. I
didn't check the history to know if that's actually true.
David
